Hi Thomas Sure, I will do it ASAP! Thank you for the helps!
Regards, Helin > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, January 20, 2015 3:54 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash > functions > > Hi Helin, > > 2014-12-02 10:19, Helin Zhang: > > Hash filter control has been implemented for i40e. It includes > > getting/setting, > > - global hash configurations (hash function type, and symmetric > > hash enable per flow type) > > - symmetric hash enable per port > > > > Signed-off-by: Helin Zhang <helin.zhang at intel.com> > > --- > > lib/librte_ether/rte_eth_ctrl.h | 63 ++++++++ > > lib/librte_pmd_i40e/i40e_ethdev.c | 294 > > +++++++++++++++++++++++++++++++++++++- > > 2 files changed, 355 insertions(+), 2 deletions(-) > > Please, could you split ethdev and i40e parts while keeping Konstantin's ack? > > [...] > > + * Each bit in valid_bit_mask[] indicates if the coresponding bit in > > Typo: corresponding > > [...] > > + /** Bit mask indicates if the coresponding bit is valid */ > > Same typo > > [...] > > + /** Details of hash filter infomation */ > > Typo: information > > > + union { > > + /* For RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT */ > > + uint8_t enable; > > + /* Global configurations of hash filter */ > > + struct rte_eth_hash_global_conf global_conf; > > + } info; > > Why these comments are not doxygen'ed? > > Sorry for nitpicking, that's the last review pass ;) > -- > Thomas
