> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Thursday, July 16, 2020 3:43 PM > To: Lukasz Wojciechowski <l.wojciec...@partner.samsung.com> > Cc: tho...@monjalon.net; dev <dev@dpdk.org>; Ruifeng Wang > <ruifeng.w...@arm.com> > Subject: Re: [dpdk-dev] [PATCH v3 2/4] config: remove unused config flags > > On Thu, Jul 9, 2020 at 3:49 PM Lukasz Wojciechowski > <l.wojciec...@partner.samsung.com> wrote: > > > > Following flags were still present in the common_base config, but they > > were not used anywhere in the code: > > * CONFIG_RTE_LIBRTE_ACL_DEBUG > > * CONFIG_RTE_LIBRTE_NFP_DEBUG_TX > > * CONFIG_RTE_LIBRTE_NFP_DEBUG_RX > > * CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG > > This could be separated from the rte_debug series. > In the armv8 crypto driver case, it is a typo (Cc: Ruifeng for info).
Yes, the armv8 crypto one is a typo. It should be CONFIG_RTE_LIBRTE_ARMV8_CRYPTO_DEBUG, without PMD. The configuration is expected to be used by armv8 crypto PMD. I will send a patch to fix this. Thanks. /Ruifeng > > $ git show 169ca3db55 |grep CRYPTO_DEBUG > +CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG=n > +#ifdef RTE_LIBRTE_ARMV8_CRYPTO_DEBUG > > > -- > David Marchand