12/07/2020 22:58, Ori Kam: > +/** > + * DPDK callback to register a PCI device.
Is this intro useful? Why specifying "DPDK"? > + * > + * This function spawns RegEx device out of a given PCI device. > + * > + * @param[in] pci_drv > + * PCI driver structure (mlx5_regex_driver). > + * @param[in] pci_dev > + * PCI device information. > + * > + * @return > + * 0 on success, 1 to skip this driver, a negative errno value otherwise > + * and rte_errno is set. > + */ Do we really need doxygen in a C file of a driver?