Ok, it looks better.
I will update it soon.
> -----Original Message-----
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Monday, July 13, 2020 4:16 PM
> To: Di, ChenxuX <chenxux...@intel.com>
> Cc: dev <dev@dpdk.org>; Xing, Beilei <beilei.x...@intel.com>; Lu, Wenzhuo
> <wenzhuo...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix display issue in flow query
>
> On Mon, Jul 13, 2020 at 8:39 AM Chenxu Di <chenxux...@intel.com> wrote:
> >
> > This patch fix the error line break in the display info of flow query
> >
> > Fixes: bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
> >
> > Signed-off-by: Chenxu Di <chenxux...@intel.com>
> > ---
> > app/test-pmd/config.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > fcbe6b6f7..7b254e484 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1425,7 +1425,10 @@ rss_config_display(struct rte_flow_action_rss
> *rss_conf)
> > if (rss_conf->queue_num == 0)
> > printf("none\n");
> > for (i = 0; i < rss_conf->queue_num; i++)
> > - printf("%d\n", rss_conf->queue[i]);
> > + if (i == rss_conf->queue_num - 1)
> > + printf("%d\n", rss_conf->queue[i]);
> > + else
> > + printf("%d ", rss_conf->queue[i]);
> >
> > printf(" function: ");
> > switch (rss_conf->func) {
> > --
> > 2.17.1
> >
>
> What do you think of this (untested) alternative?
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> fcbe6b6f74..30bee33248 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1421,11 +1421,12 @@ rss_config_display(struct rte_flow_action_rss
> *rss_conf)
> }
>
> printf("RSS:\n"
> - " queues: ");
> + " queues:");
> if (rss_conf->queue_num == 0)
> - printf("none\n");
> + printf(" none");
> for (i = 0; i < rss_conf->queue_num; i++)
> - printf("%d\n", rss_conf->queue[i]);
> + printf(" %d", rss_conf->queue[i]);
> + printf("\n");
>
>
>
> printf(" function: ");
> switch (rss_conf->func) {
>
>
> --
> David Marchand
