07/07/2020 11:22, Hemant Agrawal: > From: Gagandeep Singh <g.si...@nxp.com> > > This patch enables the packet timestamping > conditionally when Rx offload is enabled for timestamp. > > Signed-off-by: Gagandeep Singh <g.si...@nxp.com> > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c > b/drivers/net/dpaa2/dpaa2_ethdev.c > index a1f19194d..8edd4b3cd 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -524,8 +524,10 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) > return ret; > } > > +#if !defined(RTE_LIBRTE_IEEE1588) > if (rx_offloads & DEV_RX_OFFLOAD_TIMESTAMP) > - dpaa2_enable_ts = true; > +#endif > + dpaa2_enable_ts = true;
I don't understand this patch at all. There is no comment in the code, and the commit log is not very explanatory. You are lucky Ferruh is less strict than me. I remember I already said I was bored of the lack of explanations in NXP drivers.
