> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Thursday, July 9, 2020 5:58 PM > To: Joyce Kong <joyce.k...@arm.com> > Cc: Maxime Coquelin <maxime.coque...@redhat.com>; jer...@marvell.com; > Zhihong Wang <zhihong.w...@intel.com>; Xiaolong Ye > <xiaolong...@intel.com>; Beilei Xing <beilei.x...@intel.com>; Jeff Guo > <jia....@intel.com>; Mcnamara, John <john.mcnam...@intel.com>; Matan > Azrad <ma...@mellanox.com>; Shahaf Shuler <shah...@mellanox.com>; > Viacheslav Ovsiienko <viachesl...@mellanox.com>; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>; Phil Yang <phil.y...@arm.com>; > Ruifeng Wang <ruifeng.w...@arm.com>; dev <dev@dpdk.org>; nd > <n...@arm.com> > Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict with rte > restrict > > On Wed, Jul 8, 2020 at 5:21 AM Joyce Kong <joyce.k...@arm.com> wrote: > > > > > -----Original Message----- > > > From: David Marchand <david.march...@redhat.com> > > > Sent: Tuesday, July 7, 2020 10:00 PM > > > To: Joyce Kong <joyce.k...@arm.com> > > > Cc: Maxime Coquelin <maxime.coque...@redhat.com>; > > > jer...@marvell.com; Zhihong Wang <zhihong.w...@intel.com>; Xiaolong > > > Ye <xiaolong...@intel.com>; Beilei Xing <beilei.x...@intel.com>; > > > Jeff Guo <jia....@intel.com>; Mcnamara, John > > > <john.mcnam...@intel.com>; Matan Azrad <ma...@mellanox.com>; > Shahaf > > > Shuler <shah...@mellanox.com>; Viacheslav Ovsiienko > > > <viachesl...@mellanox.com>; Honnappa Nagarahalli > > > <honnappa.nagaraha...@arm.com>; Phil Yang <phil.y...@arm.com>; > > > Ruifeng Wang <ruifeng.w...@arm.com>; dev <dev@dpdk.org>; nd > > > <n...@arm.com> > > > Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict > > > with rte restrict > > > > > > On Mon, Jul 6, 2020 at 9:50 AM Joyce Kong <joyce.k...@arm.com> > wrote: > > > > > > > > '__rte_restrict' is a common wrapper for restricted pointers which > > > > can be supported by all compilers. Use '__rte_restrict' instead of > > > > '__restrict' for code consistency. > > > > > > This patch 4, 5 and 6 are simple replacements and can be squashed > > > into the first patch. > > > > > > Thanks. > > > > > The first patch is to add a common definition for lib_eal, could we > > squash the 4,5 and 6 into one replacement patch, while separate them > from the first one? > > This might be more convenient for review? > > A copy/paste commitlog hints that it did not deserve separate patches. > About easing reviews, the changes are mechanical, there is no special case. > I am not convinced but, go as you like. > > Can you provide a new revision wrt patch 1 problem? > Thanks. > > -- > David Marchand
Have just squashed the patch 4,5 and 6 into the first one, and corrected the issue with a new version. Thanks.
