Hi Thomas, > > 24/06/2020 16:26, Arek Kusztal: > > From: Fiona Trahe <fiona.tr...@intel.com> > > > > This patch adds function that can check if queue pair > > was already setup. This may be useful when dealing with > > multi process approach in cryptodev. > > That's all? No more justification? > No usage in example apps? > No addition in test apps? > Is it needed for the application? The application is in review stage right now. http://patches.dpdk.org/patch/72156/
The current patch is a cryptodev patch which should be part of RC1. The app is targeted for RC2. The API explanation in rte_cryptodev.h is I think sufficient and the usage will be Demonstrated in the app. /** + * Get the status of queue pairs setup on a specific crypto device + * + * @param dev_id Crypto device identifier. + * @param queue_pair_id The index of the queue pairs to set up. The + * value must be in the range [0, nb_queue_pair + * - 1] previously supplied to + * rte_cryptodev_configure(). + * @return + * - 0: qp was not configured + * - 1: qp was configured + * - -EINVAL: device was not configured + */ > > I don't know cryptodev enough, but I can tell with ethdev experience > that we are a lot more demanding when adding a new API in ethdev. > We are still fixing the API errors done years ago in ethdev, > and it is very difficult to deprecate what was used in the past. > I hope my fear is wrong and you are not doing the same errors > as we did in ethdev, it would be a pity. >
