08/07/2020 10:25, Fady Bader: > --- /dev/null > +++ b/lib/librte_eal/windows/include/netinet/in.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2020 Mellanox Technologies, Ltd > + */
As said previously, the license and copyright are not correct. Please keep the original copyright. Given there is no invention here, can we consider it can be re-licensed as BSD with your copyright? I think we can, but I prefer having this discussion openly. > +#ifndef _IN_H_ > +#define _IN_H_ > + > +#define IPPROTO_IP 0 > +#define IPPROTO_HOPOPTS 0 > +#define IPPROTO_IPV4 4 /* IPv4 encapsulation */ > +#define IPPROTO_IPIP IPPROTO_IPV4 /* for compatibility */ > +#define IPPROTO_TCP 6 > +#define IPPROTO_UDP 17 > +#define IPPROTO_IPV6 41 /* IP6 header */ > +#define IPPROTO_ROUTING 43 /* IP6 routing header */ > +#define IPPROTO_FRAGMENT 44 /* IP6 fragmentation header */ > +#define IPPROTO_GRE 47 /* General Routing Encap. */ > +#define IPPROTO_ESP 50 /* IP6 Encap Sec. Payload */ > +#define IPPROTO_AH 51 /* IP6 Auth Header */ Why IP6 for ESP and AH. Isn't it IPsec? > +#define IPPROTO_NONE 59 /* IPv6 no next header */ > +#define IPPROTO_DSTOPTS 60 /* IP6 destination option */ > +#define IPPROTO_SCTP 132 /* Stream Control Transmission Protocol */ There are some strange tabs above. Please replace IP6 with IPv6. Which values are really used currently in DPDK? Or which ones are not?
