Hi Jijiang, On 01/16/2015 03:31 AM, Jijiang Liu wrote: > This patch enables i40e TSO feature for both non-tunneling packet and UDP > tunneling packet. > > Signed-off-by: Jijiang Liu <jijiang.liu at intel.com> > Signed-off-by: Miroslaw Walukiewicz <miroslaw.walukiewicz at intel.com> > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 3 +- > lib/librte_pmd_i40e/i40e_rxtx.c | 111 +++++++++++++++++++++++++++--------- > lib/librte_pmd_i40e/i40e_rxtx.h | 13 ++++ > 3 files changed, 98 insertions(+), 29 deletions(-)
At first sight, the patch looks good, but I think one information is missing: how it was validated? Did you use csumonly? As we have a pending discussion on how to rework it, I think I should include this test case in the specification. A description of which mbufs fields should be filled in case of tunneling packet would be useful for people willing to use this API. Does it match the case 8) of http://dpdk.org/ml/archives/dev/2015-January/011127.html ? Regards, Olivier
