2015-01-16 15:10, Declan Doherty:
> In commit 2fc8d6d the behaviour of function rte_is_power_of_2 was
> changed to not return true for 0. memzone_reserve_aligned_thread_unsafe
> and rte_malloc_socket both make the assumption that for align = 0
> !rte_is_power_of_2(align) will return false. This patch adds a check
> that align parameter is non-zero before doing the power of 2 check
>
> Signed-off-by: Declan Doherty <declan.doherty at intel.com>
[...]
> - if (!rte_is_power_of_2(align)) {
> + if (align ? !rte_is_power_of_2(align) : 0) {
[...]
> - if (size == 0 || !rte_is_power_of_2(align))
> + if (size == 0 || align ? !rte_is_power_of_2(align) : 0)
I don't understand why you write "align ? !rte_is_power_of_2(align) : 0"
instead of the more readable "align && !rte_is_power_of_2(align)" ?
Pablo acked it so I guess there is something obvious I'm missing.
--
Thomas
