07/07/2020 16:45, Ray Kinsella: > Minor changes to the abi policy for windows.
It looks like you were not fast enough to comment in the original thread :) Please add a Fixes line to reference the original commit. > Signed-off-by: Ray Kinsella <m...@ashroe.eu> > --- > doc/guides/contributing/abi_policy.rst | 4 +++- > doc/guides/windows_gsg/intro.rst | 6 +++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/contributing/abi_policy.rst > b/doc/guides/contributing/abi_policy.rst > index d0affa9..8e70b45 100644 > --- a/doc/guides/contributing/abi_policy.rst > +++ b/doc/guides/contributing/abi_policy.rst > @@ -40,7 +40,9 @@ General Guidelines > maintaining ABI stability through one year of DPDK releases starting from > DPDK 19.11. This policy will be reviewed in 2020, with intention of > lengthening the stability period. Additional implementation detail can be > - found in the :ref:`release notes <20_02_abi_changes>`. > + found in the :ref:`release notes <20_02_abi_changes>`. Please note that > this > + policy does not currently apply to the :doc:`Window build Window -> Windows > + <../windows_gsg/intro>`. > > What is an ABI? > ~~~~~~~~~~~~~~~ > diff --git a/doc/guides/windows_gsg/intro.rst > b/doc/guides/windows_gsg/intro.rst > index 58c6246..707afd3 100644 > --- a/doc/guides/windows_gsg/intro.rst > +++ b/doc/guides/windows_gsg/intro.rst > @@ -19,6 +19,6 @@ compile. Support is being added in pieces so as to limit > the overall scope > of any individual patch series. The goal is to be able to run any DPDK > application natively on Windows. > > -The :doc:`../contributing/abi_policy` cannot be respected for Windows. > -Minor ABI versions may be incompatible > -because function versioning is not supported on Windows. > +The :doc:`../contributing/abi_policy` does not apply to the Windows build, as > +function versioning is not supported on Windows, therefore minor ABI versions > +may be incompatible. Please I really prefer we split lines logically rather than filling the space: The :doc:`../contributing/abi_policy` does not apply to the Windows build, as function versioning is not supported on Windows, therefore minor ABI versions may be incompatible.
