02/07/2020 12:19, Ciara Power: > +/** > + * Add a container to a dictionary. A container is an existing telemetry data > + * array. The dict the container is to be added to must have been started by > + * rte_tel_data_start_dict(). The container must be an array of type > + * uint64_t/int/string. > + * > + * @param d > + * The data structure passed to the callback > + * @param val > + * The pointer to the container to be stored in the dict. > + * @param keep > + * Flag to indicate that the container memory should not be automatically > + * freed by the telemetry library once it has finished with the data. > + * 1 = keep, 0 = free. > + * @return > + * 0 on success, negative errno on error > + */ > +__rte_experimental > +int > +rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name, > + struct rte_tel_data *val, int keep);
Please fix this miss: rte_telemetry.h:233: warning: The following parameter of rte_tel_data_add_dict_container(struct rte_tel_data *d, const char *name, struct rte_tel_data *val, int keep) is not documented: + parameter 'name'