On Thu, Jan 15, 2015 at 11:54:52PM +0000, Ananyev, Konstantin wrote: > Hi, > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > > Sent: Thursday, January 15, 2015 8:34 PM > > To: Thomas Monjalon > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. > > > > On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon <thomas.monjalon at > > 6wind.com> > > wrote: > > > > > 2015-01-09 04:41, Ravi Kerur: > > > > Thomas, > > > > > > > > Please let me know how I can move forward on this. If i confine changes > > > in > > > > e1000/ directory to e1000_osdep.h file only and the rest in PMD will > > > > that > > > > work? The reason I ask is because of following comment in README file. > > > > > > > > ... > > > > Few changes to the original FreeBSD sources were made to: > > > > - Adopt it for PMD usage mode: > > > > e1000_osdep.c > > > > e1000_osdep.h > > > > ... > > Yes, if needed you can modify these files. > In fact, these files are the only 2 that are allowed to be modified inside > e1000 sub-directory. > As I understand you plan to implement E1000_READ_FLASH_REG and > E1000_WRITE_FLASH_REG > macros properly, correct? > Konstantin >
As a cleanup we should really look to move these two files out of the e1000 subdirectory (and similarly for the ixgbe versions etc.), so as to give a cleaner and more manageable separation between what can be edited or not. /Bruce
