> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Friday, July 3, 2020 11:39 PM > To: Phil Yang <phil.y...@arm.com> > Cc: dev <dev@dpdk.org>; Olivier Matz <olivier.m...@6wind.com>; David > Christensen <d...@linux.vnet.ibm.com>; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>; Ruifeng Wang > <ruifeng.w...@arm.com>; nd <n...@arm.com> > Subject: Re: [dpdk-dev] [PATCH] mbuf: use c11 atomics for refcnt operations > > On Thu, Jun 11, 2020 at 12:26 PM Phil Yang <phil.y...@arm.com> wrote: > > > > Use c11 atomics with explicit ordering instead of rte_atomic ops which > > enforce unnecessary barriers on aarch64. > > > > Signed-off-by: Phil Yang <phil.y...@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > > I did not look at the details, but this patch is refused by the ABI > check in Travis.
Thanks, David. The ABI issue is the name of 'rte_mbuf_ext_shared_info::refcnt_atomic' changed to 'rte_mbuf_ext_shared_info::refcnt' at rte_mbuf_core.h. I made this change just to simplify the name of the variable. Revert the 'rte_mbuf_ext_shared_info::refcnt' to refcnt_atomic can fix this issue. I will update it in v2. Thanks, Phil > > > -- > David Marchand
