30/06/2020 10:10, Wisam Jaddo: > The hairpin queue is the one that start from normal rxq, > and will be less than nr_queues where nr_queues is the > sum of normal and hairpin > > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > Cc: wis...@mellanox.com > > Signed-off-by: Wisam Jaddo <wis...@mellanox.com>
You should take this opportunity to document the logic for the allocation and peering of hairpin queues. It would be good to add short code comments for the variables as well. It confusing to have hairpinq and hairpin_q variables. Currently, we cannot really understand whether this fix is good or not. On hairpin topic, I suggest fixing this typo: hairping-rss -> hairpin-rss