04/07/2020 16:44, Ajit Khaparde: > On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob <jerinjac...@gmail.com> wrote: > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > library(ethdev). > > Please depreciate the old API. > > We should not have two separate paths for the same function in the > > same ethdev library. It is pain for app and driver developers. > > > > With the above deprecation notice, > > Acked-by: Jerin Jacob <jer...@marvell.com> > > > I am fine with the proposed RTE_FLOW_ACTION_TYPE_SAMPLE. But.. > > When rte_eth_mirror_rule_set() is deprecated, are we going to add > RTE_FLOW_ACTION_TYPE_MIRROR for full fledged mirror action? > Or we are proposing to use RTE_FLOW_ACTION_TYPE_SAMPLE with > ratio of 1 to mirror all packets, thereby doing away with the need for > a separate RTE_FLOW_ACTION_TYPE_MIRROR?
The idea is to use RTE_FLOW_ACTION_TYPE_SAMPLE with ratio=1 for mirroring.
