> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Tuesday, June 30, 2020 2:26 AM
> To: Fady Bader <f...@mellanox.com>
> Cc: dev@dpdk.org; Tasnim Bashar <tbas...@mellanox.com>; Tal Shnaiderman
> <tal...@mellanox.com>; Yohad Tor <yoh...@mellanox.com>;
> dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com;
> ocard...@microsoft.com; pallavi.ka...@intel.com; ranjit.me...@intel.com;
> olivier.m...@6wind.com; arybche...@solarflare.com; m...@ashroe.eu;
> nhor...@tuxdriver.com
> Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on
> Windows
>
> 22/06/2020 13:55, Fady Bader:
> > Function versioning is not needed on Windows, also the function
> > versioning implementation is not supported by Windows.
>
> I think it was said that "not needed" is not right.
> Let's just say that it is not supported for now.
Ok, I'll change.
>
> > Function versioning was disabled on Windows.
> >
> > Signed-off-by: Fady Bader <f...@mellanox.com>
> > ---
> > --- a/lib/librte_eal/include/rte_function_versioning.h
> > +++ b/lib/librte_eal/include/rte_function_versioning.h
> > +#ifdef RTE_EXEC_ENV_WINDOWS
> > +#undef RTE_BUILD_SHARED_LIB
> > +#endif
>
> This trick is a bit weird but works.
> A comment is missing to explain that function versioning is disabled but
> shared
> libraries are allowed for Windows.
Sure, I'll add a comment to explain.
>
>
