Hi Ferruh > -----Original Message----- > From: Yigit, Ferruh > Sent: Monday, June 22, 2020 8:00 PM > To: Sun, GuinanX <guinanx....@intel.com>; dev@dpdk.org > Cc: Chylkowski, JakubX <jakubx.chylkow...@intel.com> > Subject: Re: [dpdk-dev] [PATCH 13/21] net/ixgbe/base: modify Klocwork hits > for DDK 7.0 > > On 6/12/2020 4:24 AM, Guinan Sun wrote: > > Fix issues found by Klocwork for DDK 7.0 > > This doesn't say much on its own, can you please document the actual issues > fixed, like "fix unchecked return value" and I think can drop the Klocwork > reference, and even not asking what DDK is ... >
We classified the inspection results and divided them into the following two types. The first one is the return value check. The second is type conversion. In addition, regarding this part of the content, we think it is to improve the code style. If it is a fix, the modified content is more scattered, and it is not easy to collect the fix version. So, the title is tentatively 'modify coding style'. > Feel free to split patch into multiple patches if there are multiple types of > issues > have been fixed. First of all, I agree with you, but for the improvement of coding style, it is not necessary to split into multiple patches, because this has nothing to do with the function, it is just an improvement point. If the function is different, it will be split into different patches. > > > > > Signed-off-by: Jakub Chylkowski <jakubx.chylkow...@intel.com> > > Signed-off-by: Guinan Sun <guinanx....@intel.com> > > <...>
