Hi Jerin, >From: Jerin Jacob <jerinjac...@gmail.com> >Sent: Sunday, June 28, 2020 5:23 AM > >---------------------------------------------------------------------- >On Sun, Jun 28, 2020 at 11:29 AM Rasesh Mody <rm...@marvell.com> wrote: >> >> Add support for .get_reg eth_dev ops which will be used to collect the >> firmware debug data. >> >> PMD on detecting on some HW errors will collect the FW/HW Dump to a >> buffer and then it will save it to a file implemented in >> qede_save_fw_dump(). >> >> Dump file location and name: >> Location: <RTE_SDK> or DPDK root >> Name: qede_pmd_dump_mm-dd-yy_hh-mm-ss.bin >> >> DPDK applications can initiate a debug data collection by invoking >> DPDK library’s rte_eth_dev_get_reg_info() API. This API invokes >> .get_reg() interface in the PMD. >> >> PMD implementation of .get_reg() collects the FW/HW Dump, saves it to >> data field of rte_dev_reg_info and passes it to the application. It’s >> the responsibility of the application to save the FW/HW Dump to a file. >> We recommendation using the file name format used by >qede_save_fw_dump(). >> >> Signed-off-by: Rasesh Mody <rm...@marvell.com> >> Signed-off-by: Igor Russkikh <irussk...@marvell.com> >> --- >> drivers/net/qede/Makefile | 1 + >> drivers/net/qede/base/bcm_osal.c | 25 +++ >> drivers/net/qede/base/bcm_osal.h | 5 + >> drivers/net/qede/qede_ethdev.c | 1 + >> drivers/net/qede/qede_ethdev.h | 25 +++ >> drivers/net/qede/qede_regs.c | 271 >+++++++++++++++++++++++++++++++ >> 6 files changed, 328 insertions(+) >> create mode 100644 drivers/net/qede/qede_regs.c >> > >> diff --git a/drivers/net/qede/qede_ethdev.c >> b/drivers/net/qede/qede_ethdev.c index 717b80839..52a4f046b 100644 >> --- a/drivers/net/qede/qede_ethdev.c >> +++ b/drivers/net/qede/qede_ethdev.c >> @@ -2430,6 +2430,7 @@ static const struct eth_dev_ops >qede_eth_dev_ops = { >> .udp_tunnel_port_add = qede_udp_dst_port_add, >> .udp_tunnel_port_del = qede_udp_dst_port_del, >> .fw_version_get = qede_fw_version_get, >> + .get_reg = qede_get_regs, > >Please update this feature in doc/guides/nics/features/qede.ini.
Sure, I'll take care of this in v2 series. Thanks! -Rasesh > > >> };