On Mon, Jun 29, 2020 at 6:06 PM Mattias Rönnblom <mattias.ronnb...@ericsson.com> wrote: > > It's unlikely to fail, and if it does something is probably seriously > wrong with your system. You also seem to think it might fail, since you > take great care of setting errno and having non-zero return code in > __rte_getentropy().
Well, no, I don't personally think that it will fail and certainly even if a read call to /dev/random fails, the whole function will not fail. As I said, I was trying to emulate the glibc getentropy and all its semantics. > From what I recall, it was Bruce that suggested rdseed should be > included as one of the sources. I have no opinion on that particular > subject, other than I think kernel-originated randomness should have > priority. In light of new attacks on rdseed, it should probably just be removed, IMHO. https://www.phoronix.com/scan.php?page=article&item=crosstalk-srbds-vulnerability&num=1 thanks d