On 6/19/20 5:02 PM, Ferruh Yigit wrote:
> On 6/18/2020 7:59 PM, Matan Azrad wrote:
>> A new vDPA driver feature was added to query the virtq statistics from
>> the HW.
>>
>> Use this feature to show the HW queues statistics for the virtqs.
>>
>> Command description: stats X Y.
>> X is the device ID.
>> Y is the queue ID, Y=0xffff to show all the virtio queues statistics of
>> the device X.
>>
>> Signed-off-by: Matan Azrad <ma...@mellanox.com>
>> Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>
>
> <...>
>
>> +
>> +static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
>> + __attribute__((unused)) void *data)
>
> replacing "__attribute__((unused))" with '__rte_unused' while merging.
>
> Please check checkpatch output, it now has a warning for it:
> http://mails.dpdk.org/archives/test-report/2020-June/137330.html
> "
> Warning in /examples/vdpa/main.c:
> Using compiler attribute directly
> "
>
Thanks Ferruh!
It would be great if the script printed the line number.
Maxime
