15/06/2020 23:46, Gaëtan Rivet: > On 10/06/20 17:17 +0000, Parav Pandit wrote: > > + DRV_LOG(ERR, "Invalid mlx5 classes %s. Maybe typo in device" > > + " class argument setting?", value); > > Error message should not be cut in half, it makes it difficult to grep. > If you differentiate between typo in name and invalid combo you could > directly warn the user about the proper error. > > (You can ignore the warning from checkpatch.sh about the long lines on a > string if there is one.)
The best is to cut the message after variable placeholder. Here you can cut at the end of the first sentence "%s. "
