On Mon, 8 Jun 2020 17:46:40 +0100 Bruce Richardson <bruce.richard...@intel.com> wrote:
> Rather than continuing to recommend an 80-char line limit, let's take a hint > from the Linux kernel[1] and aim for an 100-char recommended limit instead. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > --- > devtools/checkpatches.sh | 2 +- > doc/guides/contributing/coding_style.rst | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index 158087f1c..4970ed830 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -15,7 +15,7 @@ VALIDATE_NEW_API=$(dirname $(readlink -f > $0))/check-symbol-change.sh > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to a > valid path > # to a dictionary.txt file if dictionary.txt is not in the default location. > codespell=${DPDK_CHECKPATCH_CODESPELL:-enable} > -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} > > # override default Linux options > options="--no-tree" > diff --git a/doc/guides/contributing/coding_style.rst > b/doc/guides/contributing/coding_style.rst > index 4efde93f6..1db3a7bbe 100644 > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -21,7 +21,7 @@ The rules and guidelines given in this document cannot > cover every situation, so > * In the case of creating new files, the style should be consistent within > each file in a given directory or module. > * The primary reason for coding standards is to increase code readability > and comprehensibility, therefore always use whatever option will make the > code easiest to read. > > -Line length is recommended to be not more than 80 characters, including > comments. > +Line length is recommended to be not more than 100 characters, including > comments. > [Tab stop size should be assumed to be 8-characters wide]. > > .. note:: I would even support going to 120 characters. Acked-by: Stephen Hemminger <step...@networkplumber.org>
