On Sun, 31 May 2020 16:02:21 +0300 Andrew Rybchenko <arybche...@solarflare.com> wrote:
[snip] > > > > +#ifndef RTE_EXEC_ENV_WINDOWS > > #include <rte_trace_point_register.h> > > +#endif > > I really dislike the approach. It adds too many conditional > compilation statements which make code harder to read. > > You can have dummy implementation of these functions on > Windows to avoid the conditional compilation. Memory management series, on which this patchset depends, does have such wrappers: http://patchwork.dpdk.org/patch/70565/. -- Dmitry Kozlyuk
