> -----Original Message-----
> From: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> Sent: Thursday, May 21, 2020 7:17 AM
> To: Fady Bader <f...@mellanox.com>; dev@dpdk.org
> Cc: Thomas Monjalon <tho...@monjalon.net>; Tal Shnaiderman
> <tal...@mellanox.com>; Yohad Tor <yoh...@mellanox.com>;
> olivier.m...@6wind.com; harini.ramakrish...@microsoft.com;
> ocard...@microsoft.com; anand.ra...@intel.com;
> ranjit.me...@intel.com; dmitry.kozl...@gmail.com; Honnappa Nagarahalli
> <honnappa.nagaraha...@arm.com>; nd <n...@arm.com>; nd <n...@arm.com>
> Subject: RE: [dpdk-dev] [PATCH v2] ring: build on Windows
>
> <snip>
>
> > Subject: [dpdk-dev] [PATCH v2] ring: build on Window
> ^^^^ change this
> to 'eal'.
>
> Even though the compilation error points to rte_ring, this is not a issue in
> rte_ring library. Suggest changing the commit message to something like
> "eal: add per_lcore__rte_errno to export list for Windows".
>
> >
> > Exported per_lcore__rte_errno function to compile ring for windows.
> >
> > compilation error logs:
> > librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol
> > per_lcore__rte_errno referenced in function rte_ring_lookup
> >
> > The cause was that per_lcore__rte_errno function wasn't included in
> > the export list.
> > To solve this per_lcore__rte_errno was added to the Windows export list.
> >
> > Signed-off-by: Fady Bader <f...@mellanox.com>
> > Depends-on: series-9374 ("Windows basic memory management")
> > ---
> > lib/librte_eal/rte_eal_exports.def | 1 +
> > lib/librte_eal/rte_eal_version.map | 3
> > +++
> > lib/meson.build | 5 ++++-
> > 3 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/rte_eal_exports.def
> > b/lib/librte_eal/rte_eal_exports.def
> > index 854b83bcd..cbb6b8cfe 100644
> > --- a/lib/librte_eal/rte_eal_exports.def
> > +++ b/lib/librte_eal/rte_eal_exports.def
> > @@ -1,5 +1,6 @@
> > EXPORTS
> > __rte_panic
> > + per_lcore__rte_errno
> > rte_calloc
> > rte_calloc_socket
> > rte_eal_get_configuration
> > diff --git a/lib/librte_eal/rte_eal_version.map
> > b/lib/librte_eal/rte_eal_version.map
> > index bdd014638..0f1b983b8 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -390,4 +390,7 @@ EXPERIMENTAL {
> > rte_trace_point_lookup;
> > rte_trace_regexp;
> > rte_trace_save;
> > +
> > + # added in 20.08
> > + __emutls_v.per_lcore__rte_errno;
> Not sure why this is required. per_lcore__rte_errno is present already in this
> file.
It is needed for the mingw64 compilation on windows.
>
> > };
> > diff --git a/lib/meson.build b/lib/meson.build index
> > d190d84ef..98ee5ec57
> > 100644
> > --- a/lib/meson.build
> > +++ b/lib/meson.build
> > @@ -36,7 +36,10 @@ libraries = [
> > 'flow_classify', 'bpf', 'graph', 'node']
> >
> > if is_windows
> > - libraries = ['kvargs','eal'] # only supported libraries for windows
> > + libraries = [
> > + 'kvargs',
> > + 'eal',
> > + 'ring'] # only supported libraries for windows
> > endif
> >
> > default_cflags = machine_args
> > --
> > 2.16.1.windows.4
