Get, this is for queue group, thanks.
> -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, May 20, 2020 5:31 PM > To: Junyu Jiang <junyux.ji...@intel.com>; dev@dpdk.org > Cc: Yang, Qiming <qiming.y...@intel.com>; Jiang, JunyuX > <junyux.ji...@intel.com>; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch > filter > > Hi, Junyu > > > -----Original Message----- > > From: dev <dev-boun...@dpdk.org> On Behalf Of Junyu Jiang > > Sent: Wednesday, May 6, 2020 11:05 AM > > To: dev@dpdk.org > > Cc: Yang, Qiming <qiming.y...@intel.com>; guinanx....@intel.com X > > <junyux.ji...@intel.com>; sta...@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in > > switch filter > > > > The number of queues in queue group should be checked before using it. > > This patch fixed the issue. > > > > Fixes: 47d460d63233 ("net/ice: rework switch filter") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Junyu Jiang <junyux.ji...@intel.com> > > Tested-by: Qimai Xiao <qimaix.x...@intel.com> > > --- > > drivers/net/ice/ice_switch_filter.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ice/ice_switch_filter.c > > b/drivers/net/ice/ice_switch_filter.c > > index 179430136..c2762e331 100644 > > --- a/drivers/net/ice/ice_switch_filter.c > > +++ b/drivers/net/ice/ice_switch_filter.c > > @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > > switch (action_type) { > > case RTE_FLOW_ACTION_TYPE_RSS: > > act_qgrop = action->conf; > > + if (act_qgrop->queue_num <= 1) > > + goto error; > > Why do you ban the case of queue num =1? > > > rule_info->sw_act.fltr_act = > > ICE_FWD_TO_QGRP; > > rule_info->sw_act.fwd_id.q_id = > > -- > > 2.17.1