On Wed, May 13, 2020 at 12:48 PM Gaetan Rivet <gr...@u256.net> wrote:
>
> Empty strings are forbidden as input to rte_pci_addr_parse().
> It is explicitly enforced in BDF parsing as parsing the bus
> field will immediately fail. The related check is commented.
>
> It is implicitly enforced in DBDF parsing, as the domain would be
> parsed to 0 without error, but the check `end[0] != ':'` afterward
> will return -EINVAL.
>
> Enforcing consistency between parsers by reading the code is not helped
> by this property being implicit. Add a comment to explain.
>
> Signed-off-by: Gaetan Rivet <gr...@u256.net>
Acked-by: Darek Stojaczyk <dariusz.stojac...@intel.com>


Applied, thanks.

-- 
David Marchand

Reply via email to