Re: [dpdk-dev] [PATCH v2 1/4] librte_ethdev: Introduce a function to release HW rings

[Burakov, Anatoly]

On 13-May-20 10:15 AM, Renata Saiakhova wrote:

Free previously allocated memzone for HW rings

Signed-off-by: Renata Saiakhova <renata.saiakh...@ekinops.com>
---
  lib/librte_ethdev/rte_ethdev.c           | 30 ++++++++++++++++++++++--
  lib/librte_ethdev/rte_ethdev_driver.h    | 19 +++++++++++++++
  lib/librte_ethdev/rte_ethdev_version.map |  1 +
  3 files changed, 48 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 72aed59a5..7200ef48c 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -4181,6 +4181,10 @@ rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, 
uint16_t queue_id)
        return fd;
  }

+#define ETH_DMA_MZONE_NAME(_name, _port_id, _queue_id, _ring_name) \

+       snprintf(_name, sizeof(_name), "eth_p%d_q%d_%s", \
+                       _port_id, _queue_id, _ring_name)
+
  const struct rte_memzone *
  rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
                         uint16_t queue_id, size_t size, unsigned align,
@@ -4190,8 +4194,7 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, 
const char *ring_name,
        const struct rte_memzone *mz;
        int rc;

- rc = snprintf(z_name, sizeof(z_name), "eth_p%d_q%d_%s",

-                     dev->data->port_id, queue_id, ring_name);
+       rc = ETH_DMA_MZONE_NAME(z_name, dev->data->port_id, queue_id, 
ring_name);
        if (rc >= RTE_MEMZONE_NAMESIZE) {
                RTE_ETHDEV_LOG(ERR, "ring name too long\n");
                rte_errno = ENAMETOOLONG;
@@ -4206,6 +4209,29 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, 
const char *ring_name,
                        RTE_MEMZONE_IOVA_CONTIG, align);
  }

+int __rte_experimental

+rte_eth_dma_zone_free(const struct rte_eth_dev *dev, const char *ring_name,
+               uint16_t queue_id)
+{
+       char z_name[RTE_MEMZONE_NAMESIZE];
+       const struct rte_memzone *mz;
+       int rc = 0;
+
+       rc = ETH_DMA_MZONE_NAME(z_name, dev->data->port_id, queue_id, 
ring_name);
+       if (rc >= RTE_MEMZONE_NAMESIZE) {
+               RTE_ETHDEV_LOG(ERR, "ring name too long\n");
+               return -ENAMETOOLONG;
+       }
+
+       mz = rte_memzone_lookup(z_name);
+       if (mz)
+               rc = rte_memzone_free(mz);
+
+       return rc;
+}
+
+#undef ETH_DMA_MZONE_NAME

Not sure #undef is necessary in a .c file :)

Otherwise LGTM

Acked-by: Anatoly Burakov <anatoly.bura...@intel.com>

--
Thanks,
Anatoly