Hi Xiaolong,
The purpose of this function is to clear RSS related configuration, if the RSS
filter not been enabled, this message will be printed.
The reason for printing this message is that this function will be called when
the RSS flow was previously deleted and will prompt the user if RSS is not
enabled.
When rectifying later, deleting the RSS flow will not call this function, and
this function is similar to another function but the other function does not
print the log,
so the other function is replaced by this function, but I forgot to delete the
log.
Thanks,
Alvin
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, May 7, 2020 2:32 PM
> To: Zhang, AlvinX <alvinx.zh...@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia....@intel.com>; sta...@dpdk.org
> Subject: Re: [PATCH] net/igc: remove some useless log
>
> On 04/30, alvinx.zh...@intel.com wrote:
> >From: Alvin Zhang <alvinx.zh...@intel.com>
> >
> >As title.
> >
> >Fixes: 746664d546fb (net/igc: implement flow API)
> >Cc: sta...@dpdk.org
> >
> >Signed-off-by: Alvin Zhang <alvinx.zh...@intel.com>
> >---
> > drivers/net/igc/igc_txrx.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> >diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
> >index 5b269b6..4654ec4 100644
> >--- a/drivers/net/igc/igc_txrx.c
> >+++ b/drivers/net/igc/igc_txrx.c
> >@@ -1035,10 +1035,8 @@ int eth_igc_rx_descriptor_status(void
> *rx_queue,
> >uint16_t offset) {
> > struct igc_rss_filter *rss_filter = IGC_DEV_PRIVATE_RSS_FILTER(dev);
> >
> >- if (!rss_filter->enable) {
> >- PMD_DRV_LOG(WARNING, "RSS filter not enabled!");
> >+ if (!rss_filter->enable)
> > return;
>
> Why this log is useless?
>
> >- }
> >
> > /* recover default RSS configuration */
> > igc_rss_configure(dev);
> >--
> >1.8.3.1
> >
