Thank for your explanation.
> -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@intel.com> > Sent: Wednesday, May 6, 2020 5:29 PM > To: Zhao1, Wei <wei.zh...@intel.com>; dev@dpdk.org > Cc: sta...@dpdk.org; Xing, Beilei <beilei.x...@intel.com>; > maxime.le...@6wind.com; Kevin Traynor <ktray...@redhat.com> > Subject: Re: [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each > pctype for FDIR > > On 5/6/2020 2:05 AM, Zhao1, Wei wrote: > > HI, Ferruh > > > > This is the patch enable FDIR for flow filter, so we can use this. > > > > Fixes: 14c66a451ef ("net/i40e: parse flow director filter ") > > Cc: sta...@dpdk.org > > Updated the commit log, thanks. > > > > > > >> -----Original Message----- > >> From: Yigit, Ferruh <ferruh.yi...@intel.com> > >> Sent: Thursday, April 30, 2020 6:19 PM > >> To: Zhao1, Wei <wei.zh...@intel.com>; dev@dpdk.org > >> Cc: sta...@dpdk.org; Xing, Beilei <beilei.x...@intel.com>; > >> maxime.le...@6wind.com; Kevin Traynor <ktray...@redhat.com> > >> Subject: Re: [dpdk-stable] [PATCH v4 2/3] doc: input set requirement > >> of each pctype for FDIR > >> > >> On 4/30/2020 1:52 AM, Zhao1, Wei wrote: > >>> Hi, > >>> > >>> > >>>> -----Original Message----- > >>>> From: Yigit, Ferruh <ferruh.yi...@intel.com> > >>>> Sent: Wednesday, April 29, 2020 6:35 PM > >>>> To: Zhao1, Wei <wei.zh...@intel.com>; dev@dpdk.org > >>>> Cc: sta...@dpdk.org; Xing, Beilei <beilei.x...@intel.com>; > >>>> maxime.le...@6wind.com > >>>> Subject: Re: [dpdk-stable] [PATCH v4 2/3] doc: input set > >>>> requirement of each pctype for FDIR > >>>> > >>>> On 4/29/2020 3:03 AM, Wei Zhao wrote: > >>>>> Add input set requirement info to i40e doc. > >>>>> > >>>>> Bugzilla ID: 403 > >>>> > >>>> Should this document update backported to the LTS? > >>>> If so which LTS versions are in the scope, it is better if you can > >>>> add a fixes tag to help us to figure out that. > >>> > >>> Maybe we can use this, it is the latest update for i40 doc. > >>> Btw, this is not a bug although it is report in bug list. > >>> > >>> Fixes: 3d91e097a352 ("doc: add feature support matrix link in i40e > >>> guide ") > >> > >> Hi Wei, > >> > >> I agree this is not bug, but this documents a limitation for users. > >> And if this limitation is valid for the stable trees, it make sense > >> to update documentation for those releases too, so that they can have > correct/complete documentation. > >> I will add the "sta...@dpdk.org" tag to request the backport. > >> > >> But next question is for which stable trees is this limitation valid, > >> it would be wrong to document a limitation that doesn't have the > >> feature, how a stable tree maintainer can know if this issue is valid for a > specific stable tree or not. > >> For that we need the commit that introduces the mentioned feature > >> (and the limitation), I don't think the commit above really is that > >> commit, that is unrelated doc commit, but we need the commit for code. > >> > >> If you can provide correct fixes line, I will update it in the next-net. > >> > >> Thanks, > >> ferruh > >> > >> > >>> > >>>> > >>>>> Signed-off-by: Wei Zhao <wei.zh...@intel.com> > >>>>> --- > >>>>> doc/guides/nics/i40e.rst | 7 +++++++ > >>>>> 1 file changed, 7 insertions(+) > >>>>> > >>>>> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > >>>>> index 416b3904e..f085a357c 100644 > >>>>> --- a/doc/guides/nics/i40e.rst > >>>>> +++ b/doc/guides/nics/i40e.rst > >>>>> @@ -747,6 +747,13 @@ Use 16 Bytes RX Descriptor Size As i40e > PMD > >>>>> supports both 16 and 32 bytes RX descriptor sizes, and 16 bytes > >>>>> size can > >>>> provide helps to high performance of small packets. > >>>>> Configuration of ``CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC`` in > >>>>> config > >>>> files can be changed to use 16 bytes size RX descriptors. > >>>>> > >>>>> +input set requirement of each pctype for FDIR > >>>>> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >>>>> + > >>>>> +Each PCTYPE can only have one specific FDIR input set at one time. > >>>>> +For example, if creating 2 rte_flow rules with different input > >>>>> +set for one PCTYPE, it is will fail and return the info "Conflict > >>>>> +with the first rule's > >>>> input set", which means the current rule's input set is conflict > >>>> with the first rule's. Remove the first rule if want to change the > >>>> input set of the > >> PCTYPE. > >>>>> + > >>>>> Example of getting best performance with l3fwd example > >>>>> ------------------------------------------------------ > >>>>> > >>>>> > >>> > >