> -----Original Message-----
> From: Ferruh Yigit <ferruh.yi...@intel.com>
> Sent: Friday, May 1, 2020 11:00 PM
> To: Ruifeng Wang <ruifeng.w...@arm.com>; wenzhuo...@intel.com;
> konstantin.anan...@intel.com; jer...@marvell.com;
> vikto...@rehivetech.com
> Cc: dev@dpdk.org; Gavin Hu <gavin...@arm.com>; Honnappa Nagarahalli
> <honnappa.nagaraha...@arm.com>; juraj.lin...@pantheon.tech; nd
> <n...@arm.com>
> Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: add support for aarch32
>
> On 4/24/2020 7:50 AM, Ruifeng Wang wrote:
> > Expand vector PMD support to aarch32.
> >
> > Signed-off-by: Ruifeng Wang <ruifeng.w...@arm.com>
> > Reviewed-by: Gavin Hu <gavin...@arm.com>
> > ---
> > drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h
> > b/drivers/net/ixgbe/ixgbe_rxtx.h index 20a8b291d..7e09291b2 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.h
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.h
> > @@ -33,7 +33,7 @@
> >
> > #define RTE_IXGBE_DESCS_PER_LOOP 4
> >
> > -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> > +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> > +defined(RTE_ARCH_ARM)
> > #define RTE_IXGBE_RXQ_REARM_THRESH 32
> > #define RTE_IXGBE_MAX_RX_BURST
> RTE_IXGBE_RXQ_REARM_THRESH
> > #endif
> > @@ -117,7 +117,7 @@ struct ixgbe_rx_queue {
> > uint8_t using_ipsec;
> > /**< indicates that IPsec RX feature is in use */ #endif -#if
> > defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> > +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> > +defined(RTE_ARCH_ARM)
> > uint16_t rxrearm_nb; /**< number of remaining to be re-
> armed */
> > uint16_t rxrearm_start; /**< the idx we start the re-arming
> from */
> > #endif
> >
>
>
> This is not enough for Make build, since it doesn't compile
> 'ixgbe_rxtx_vec_neon.c' for 'RTE_ARCH_ARM', it needs to be updated.
>
Agreed. Will update Makefile to include this.
>
> btw, also should IXGBE_PMD enabled by default 'defconfig_arm-armv7a-
> linuxapp-gcc'? Which is by default disabled currently.
Yes. We can enable IXGBE_PMD by default since it now compiles.
Will change it in next version.
