Cc: Ray. On Tue, May 5, 2020 at 4:10 PM Hemant Agrawal <hemant.agra...@nxp.com> wrote: > > This patch moves the internal symbols to INTERNAL sections > so that any change in them is not reported as ABI breakage.
Talking about the series (not just this patch as I did not look at the details), travis reported a build issue: https://travis-ci.com/github/ovsrobot/dpdk/builds/163985766 It looks like there is a versioned symbol for a static function of one of those drivers. $ git grep dpaa2_get_qbman_swp origin/master origin/master:drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:static struct dpaa2_dpio_dev *dpaa2_get_qbman_swp(int lcoreid) origin/master:drivers/bus/fslmc/portal/dpaa2_hw_dpio.c: dpaa2_io_portal[lcore_id].dpio_dev = dpaa2_get_qbman_swp(lcore_id); origin/master:drivers/bus/fslmc/portal/dpaa2_hw_dpio.c: dpaa2_get_qbman_swp(lcore_id); origin/master:drivers/bus/fslmc/rte_bus_fslmc_version.map: dpaa2_get_qbman_swp; Once fixed, I don't understand how you chose to move some symbols to INTERNAL and not others. Can you explain the differences? Finally, I would still expect a failure in the ABI check even if using __rte_internal marking. Marking them internal will make you free of changing those symbols in the future. The problem is the transient state we are in. In 20.02 (and I suppose 19.11 too), those symbols were exported and versioned as stable DPDK_20. So with the current ABI check script, this move will still be seen as a removal. -- David Marchand
