> -----Original Message----- > From: Lukasz Wojciechowski <l.wojciec...@partner.samsung.com> > Sent: Monday, May 4, 2020 9:50 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com>; dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; phil.y...@arm.com > Subject: Re: [dpdk-dev] [PATCH] test/service: add perf test for service on app > lcore
<snip code> > > + unregister_all(); > > return TEST_SUCCESS; > > } > > > > Hi Harry, Hey Lukasz, > I like the idea of adding this test. I checked it and it works fine. Thanks for testing - please send a "Tested-by: .. <email>" and we can track your input into the git logs :) > However have you considered adding it as a separate testcase or even > better as "service_perf_autotest" command ? Actually I started implementing a new function with a very similar name, but realized that the configuration/mapping would be duplicated, only to have a different named test... so opted for this smaller diff solution. > With your changes the: service_app_lcore_mt_safe and > service_app_lcore_mt_unsafe unit tests cases have multiple > functionalities: they test simultaneous execution of service and they do > performance checks. Correct - if you feel strongly that this isn't right I can refactor to a v2, however I expect there would be more duplicated code to manage, and hence I decided the above approach was simpler and easier. > Best regards > Lukasz Regards, -Harry
