>-----Original Message----- >From: David Marchand <david.march...@redhat.com> >Sent: Monday, May 4, 2020 7:47 PM >To: Sunil Kumar Kori <sk...@marvell.com>; Gaetan Rivet <gr...@u256.net> >Cc: Stephen Hemminger <step...@networkplumber.org>; Jerin Jacob >Kollanukkaran <jer...@marvell.com>; dev <dev@dpdk.org> >Subject: [EXT] Re: [PATCH v5 1/1] bus/pci: optimise scanning with >whitelist/blacklist > >External Email > >---------------------------------------------------------------------- >On Sat, May 2, 2020 at 9:42 AM Sunil Kumar Kori <sk...@marvell.com> wrote: >> diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h >> index a205d4d9f..3a9da7322 100644 >> --- a/drivers/bus/pci/private.h >> +++ b/drivers/bus/pci/private.h >> @@ -42,6 +42,17 @@ int rte_pci_scan(void); void pci_name_set(struct >> rte_pci_device *dev); >> >> +/** >> + * Validate whether a device with given pci address should be ignored or >not. >> + * >> + * @param pci_addr >> + * PCI address of device to be validated >> + * @return >> + * 1: if device is to be ignored, >> + * 0: if device is to be scanned, > >true/false > > >> + */ >> +bool rte_pci_ignore_device(const struct rte_pci_addr *pci_addr); > >Gaetan, private API must not be prefixed with rte_, this is for public APIs >only. >I noticed inconsistencies in the pci bus some time ago, I will fix this patch >for >now and send some followup patches I had in store. > > > >> + >> /** >> * Add a PCI device to the PCI Bus (append to PCI Device list). This >> function >> * also updates the bus references of the PCI Device (and the generic >> device > >Sunil, no need to send a new version, I will fix this when applying. > > Ack.
>Thanks. > >-- >David Marchand
