On 5/1/2020 4:14 PM, Matan Azrad wrote: > > > From: Ferruh Yigit: >> On 5/1/2020 1:45 PM, Matan Azrad wrote: >>> >>> >>> From: Ferruh Yigit: >>>> On 5/1/2020 12:28 PM, Matan Azrad wrote: >>>>> >>>>> Hi Ferruh >>>>> >>>>> From: Ferruh Yigit: >>>>>> On 5/1/2020 7:51 AM, Matan Azrad wrote: >>>>>>> Hi Ferruh >>>>>>> >>>>>>> From: Ferruh Yigit >>>>>>>> On 4/30/2020 4:53 PM, Bill Zhou wrote: >>>>>>>>> Currently, there is no way to check the aging event or to get >>>>>>>>> the current aged flows in testpmd, this patch include those >>>>>>>>> implements, it's >>>>>>>> included: >>>>>>>>> - Registering aging event when the testpmd application start, add >> new >>>>>>>>> command to control if the event expose to the applications. If it's >> be >>>>>>>>> set, when new flow be checked age out, there will be one-line >>>>>>>>> output >>>>>> log. >>>>>>>>> - Add new command to list all aged flows, meanwhile, we can set >>>>>>>> parameter >>>>>>>>> to destroy it. >>>>>>>>> >>>>>>>>> Signed-off-by: Bill Zhou <do...@mellanox.com> >>>>>>>>> --- >>>>>>>>> v2: Update the way of registering aging event, add new command >>>>>>>>> to control if the event need be print or not. Update the output >>>>>>>>> of the delete aged flow command format. > <...> >>>>>> What do you think about a more generic "set event_verbose on|off" >>>>>> command, which can control to logging for all event handlers, but >>>>>> right now only for aged events? >>>>> >>>>> Looks good to me, but maybe instead of on | off it is better to use >>>>> bitmap >>>> in order to indicate the event? >>>> >>>> No objection but not sure that level fine grain needed now, or later, >>>> why not add the basic on/off now and add the bitmap when we need to >>>> control for each event. >>> >>> It will be good to the user to reduce logs of non-interested events (maybe >> even more often) which makes his log bigger. >> >> Right now, is there any other event that logs? And how much log do they >> produce? > > I don't really familiar with all, but looks like IPSEC, VF_MBOX and AGED may > make the log bigger than others. > > So, if we open verbose for all, the events log bitmap may be very usable. >
I was thinking they are not printing anything at all, but if they do I agree with you. Thanks.
