On 11/20/2019 3:48 AM, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavat...@marvell.com>
>
> Sync mail box data structures to version 1.1.3.
> Add mail box version verification and defer initializing octeontx
> devices if mail box version mismatches.
> Update OCTEON TX limitaion with max mempool size used.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jer...@marvell.com>
<...>
> +static int
> +octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
> + struct mbox_intf_ver *intf_ver)
> +{
> + struct mbox_intf_ver kernel_intf_ver = {0};
> + struct octeontx_mbox_hdr hdr = {0};
> + int result = 0;
> +
> +
> + hdr.coproc = NO_COPROC;
> + hdr.msg = RM_INTERFACE_VERSION;
> +
> + result = octeontx_mbox_send(&hdr, &app_intf_ver, sizeof(app_intf_ver),
> + &kernel_intf_ver, sizeof(kernel_intf_ver));
> + if (result != sizeof(kernel_intf_ver)) {
> + mbox_log_err("Could not send interface version. Err=%d.
> FuncErr=%d\n",
> + result, hdr.res_code);
> + result = -EINVAL;
> + }
> +
> + if (intf_ver)
> + *intf_ver = kernel_intf_ver;
> +
> + if (app_intf_ver.platform != kernel_intf_ver.platform ||
> + app_intf_ver.major != kernel_intf_ver.major ||
> + app_intf_ver.minor != kernel_intf_ver.minor)
> + result = -EINVAL;
> +
> + return result;
> +}
Hi Pavan, Jerin,
This is an old code, but with a new version of a cross compiler [1], this is
generating a compiler note [2], can you please check if it has anything to fix
and should the note be silenced?
[1]
aarch64-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0
[2] https://pastebin.com/gYfwM5kD
.../dpdk/drivers/common/octeontx/octeontx_mbox.c: In function
‘octeontx_check_mbox_version’:
.../dpdk/drivers/common/octeontx/octeontx_mbox.c:282:1: note: parameter passing
for argument of type ‘struct mbox_intf_ver’ changed in GCC 9.1
282 | octeontx_check_mbox_version(struct mbox_intf_ver app_intf_ver,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
