> -----Original Message----- > From: Sunil Kumar Kori <sk...@marvell.com> > Sent: Tuesday, April 28, 2020 6:52 PM > To: Phil Yang <phil.y...@arm.com>; jer...@marvell.com; dev@dpdk.org > Cc: David Marchand <david.march...@redhat.com>; Ruifeng Wang > <ruifeng.w...@arm.com>; Lijian Zhang <lijian.zh...@arm.com>; nd > <n...@arm.com>; nd <n...@arm.com> > Subject: RE: [EXT] [PATCH] trace: fix build with gcc 10 >
<snip> > >> > >Hello, there is one more thread going on regarding this. Please have a look > on > >below patch. > >https://urldefense.proofpoint.com/v2/url?u=http- > >3A__patches.dpdk.org_patch_69382_&d=DwIGaQ&c=nKjWec2b6R0mOyPa > z7x > >tfQ&r=dXeXaAMkP5COgn1zxHMyaF1_d9IIuq6vHQO6NrIPjaE&m=WFCcD0E > avY > >uGMZUUoJWIQunwTAwgxAju2rK4s3Nr-t4&s=iMF8PSGMB8S- > >rDR0kJGOZ1el3MzeOKfxZQxX-Oyg54g&e= > > > >Hi Sunil, > > > >Sorry, I didn’t notice that. Thanks for the link. > > > >I have two points: > >1. Will this patch resolves both mentioned warnings/error in patch 69382 ? > >[Phil] Yes, this patch resolved the same issue mentioned by David in patch > >69382. > > > >2. David has suggested another way of doing it. Please check that too. > >[Phil] I think both David’s and my patches are correct. > >My patch can guarantee a correct ‘size’ information in snprinf(). It omits > >the > >memory allocation operation for the incorrect input arguments case. > >David’s suggestion resolves the potential directory copy fail issue and it > saves > >some memory space in the normal case. But it needs to allocate memory in > >the incorrect input case. > > > >So, I think we can bind these two patches together? > Make sense. > So can you please combine both the patches and share ? > Sure. I will update it in v2.
