On 2020-04-16 11:34 GMT-0700 Ranjit Menon wrote: [snip] > > --- /dev/null > > +++ b/lib/librte_eal/windows/include/rte_virt2phys.h [snip] > > This file is a duplicate of: <kmods>: windows/virt2phys/virt2phys.h > This is by design, since it documents the driver interface. > > So, to prevent the two files going out-of-sync, should we: > 1. Make the two filenames the same? > 2. Add comments to both files referencing each other and the need to > keep them both in sync? > 3. Do both (1) and (2)? > > This will also be an issue for the upcoming Windows netuio kernel driver > and I reckon this could be an issue for Linux kernel modules too. > > Thoughts?
I guess it won't be much of an issue in practice. When you edit driver interface you're already considering user-mode and kernel interaction, by definition of that interface, so you can't forget about the counterpart. I'd be more worried about ABI, because memory corruption in driver will crash the system, being hard to debug. Can we leverage abigail for these interfaces? -- Dmitry Kozlyuk
