22/04/2020 11:43, Akhil Goyal: > Hi Thomas, > > 14/04/2020 19:48, Thomas Monjalon: > > > 14/04/2020 19:22, De Lara Guarch, Pablo: > > > > From: Thomas Monjalon <tho...@monjalon.net> > > > > > 14/04/2020 12:22, Pablo de Lara: > > > > > > Now that capabilities are checked to see if an algorithm is > > > > > > supported > > > > > > by a device, there is no need to check for a specific version of a > > > > > > library used in a PMD. > > > > > > > > > > Yes, and even no need to check the PMD at all. > > > > > All *_TEST_TARGET_PMD_* constants should be removed. > > > > > > > > > > > > > I am currently working on this. However, I would like to split this > > > > effort > > > > into multiple patchsets. A first one addressing the problem of needing > > > > to > > check for > > > > specific information from PMDs (such as IMB_VERSION_NUM), which should > > not > > > > have any effect on the number of test cases ran for each PMD, and > > > > another > > one which > > > > addresses your comment, and that will enable test cases for all PMDs. > > > > This last patchset will require testing from all PMD maintainers and it > > > > is a less > > urgent > > > > problem to resolve, so we can decide if we want to merge it in this > > > > release or > > wait > > > > for more time in 20.08. > > > > > > Thanks for your efforts Pablo. > > > If the basic is working, I am for removing *_TEST_TARGET_PMD_* in 20.05, > > > and allow PMD maintainers to validate the tests during -rc phases. > > > > Some patches using capabilities are merged in the crypto test. > > > > What else is remaining? I see rte_cryptodev_driver_id_get() is still used. > > I think rte_cryptodev_driver_id_get() should be deprecated. > > > All of the cleanup cannot be done in one go. There are quite a few things > which need to be cleaned > 1. many test cases are checking the PMD type for specific PMDs. That need to > be removed. > Currently it is done only for the block cipher cases. > 2. many PMDs are maintaining their separate test suites. Which should be > moved to a single one > 3. there are some PDCP specific cases which need to be moved to security test. > > For #1, we need to remove all calls to rte_cryptodev_driver_id_get and every > PMD should check > If it has properly defined capabilities or not. > > I plan to do #2 and #3 for NXP platforms in a couple of week. May be before > RC2. > I have asked all the PMD maintainers to move to a single testsuite otherwise > their PMD changes will not > Be picked.
That's perfect Akhil, thanks for driving it.
