On 4/21/2020 12:06 PM, Raslan Darawsheh wrote:
> Hi,
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yi...@intel.com>
>> Sent: Tuesday, April 21, 2020 12:51 PM
>> To: Gavin Hu <gavin...@arm.com>; Raslan Darawsheh
>> <rasl...@mellanox.com>
>> Cc: dev@dpdk.org; xiaolong...@intel.com; david.march...@redhat.com;
>> Thomas Monjalon <tho...@monjalon.net>;
>> honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com;
>> phil.y...@arm.com; joyce.k...@arm.com; sta...@dpdk.org
>> Subject: Re: [patch v1] net/i40e: fix the compile issue
>>
>> On 4/21/2020 10:49 AM, Gavin Hu wrote:
>>> Using gcc version 4.8.5 20150623 (Red Hat 4.8.5-28), it reports the
>>> following compiling error:
>>>
>>> /download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:175:65: error:
>>> expected ';', ',' or ')' before 'rx_pkts' desc_to_ptype_v(uint64x2_t
>>> descs[4], struct rte_mbuf **restrict rx_pkts, ^
>>> /download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:197:51: error:
>>> expected ';', ',' or ')' before 'rxq' _recv_raw_pkts_vec(struct
>>> i40e_rx_queue *restrict rxq, struct rte_mbuf ^
>>> /download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:435:35: error:
>>> expected ';', ',' or ')' before 'rx_queue' i40e_recv_pkts_vec(void
>>> *restrict rx_queue, struct rte_mbuf **restrict rx_pkts,
>>>
>>> Fix this by using '__restrict' type qualifier, which compiles ok with
>>> old and new versions of gcc.
>>>
>>> Fixes: 8499b1748f26 ("net/i40e: restrict pointer aliasing for NEON")
>>> Cc: sta...@dpdk.org
>>>
>>> Signed-off-by: Gavin Hu <gavin...@arm.com>
> Tested-by: Raslan Darawsheh <rasl...@mellanox.com>
>>
>> Thanks Gavin.
>>
>> Raslan can you please test the patch since you can reproduce the issue?
>>
>> Thanks,
>> ferruh
>
> Just verified it's working just fine with this fix, thanks for that.
>
Squashed into relevant commit in next-net, thanks.
