> > 21/04/2020 04:29, Thomas Monjalon: > > 06/03/2020 08:08, Savinay Dharmappa: > > > test app to measures the performance of libipsec > > > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. > > > > Please make sentences in commit logs. > > > > > Signed-off-by: Savinay Dharmappa <savinay.dharma...@intel.com> > > > Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > > --- > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -1259,6 +1259,8 @@ F: lib/librte_ipsec/ > > > M: Bernard Iremonger <bernard.iremon...@intel.com> > > > F: app/test/test_ipsec.c > > > F: doc/guides/prog_guide/ipsec_lib.rst > > > +M: Savinay Dharmappa <savinay.dharma...@intel.com> > > > +F: app/test/test_ipsec_perf.c > > > M: Vladimir Medvedkin <vladimir.medved...@intel.com> > > > F: app/test/test_ipsec_sad.c > > > F: app/test-sad/ > > > > Repeating what I said on v3: > > Having one different maintainer per test file is quite ridiculous. > > The maintainers of a lib are expected to maintain the related tests. > > > In addition, reading the first lines of the file, I see two mistakes: > > > --- /dev/null > > +++ b/app/test/test_ipsec_perf.c > > @@ -0,0 +1,619 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2010-2014 Intel Corporation > > The Copyright year should be 2020 I guess. > > > + */ > > + > > +#include <stdio.h> > > +#include <rte_ip.h> > > +#include <rte_malloc.h> > > +#include <rte_ring.h> > > +#include <rte_mbuf.h> > > +#include <rte_malloc.h> > > rte_malloc.h is already included 3 lines above. > > > I have a bad feeling about this patch, > I think it should be dropped from 20.05-rc1.
If you feel patch is not good enough - sure feel free to drop it, we'll try to fix the issues and resubmit it for rc2. About having separate MAINTAINER for the test - honestly I don't understand why it is a problem for you. Obviously we would like to spread the load - what's wrong with it? Konstantin
