Hi, Shougang On 04/13, Shougang Wang wrote: >It's a normal behavior to change the link status to up after >resetting the port. So it is unnecessary to set link down before >starting port, and changing the link state(link up/down) frequently >will cause link speed unstable. > >Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") >Cc: sta...@dpdk.org > >Signed-off-by: Shougang Wang <shougangx.w...@intel.com> >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >b/drivers/net/ixgbe/ixgbe_ethdev.c >index 23b3f5b0c..206358b85 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -1196,7 +1196,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void >*init_params __rte_unused) > diag = ixgbe_bypass_init_hw(hw); > #else > diag = ixgbe_init_hw(hw); >- hw->mac.autotry_restart = false;
Why do we need this change? Seems it is not mentioned in the commit log. > #endif /* RTE_LIBRTE_IXGBE_BYPASS */ > > /* >@@ -1307,8 +1306,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void >*init_params __rte_unused) > /* enable support intr */ > ixgbe_enable_intr(eth_dev); > >- ixgbe_dev_set_link_down(eth_dev); >- > /* initialize filter info */ > memset(filter_info, 0, > sizeof(struct ixgbe_filter_info)); >-- >2.17.1 >