On Fri, 20 Feb 2015 13:15:38 +0100 Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 2015-02-12 17:18, Panu Matilainen: > > Add RTE_DEVEL_BUILD make-variable which can be used to do things > > differently when doing development vs building a release, > > autodetected from source root .git presence and overridable via > > commandline. Use it to only enable -Werror compiler flag when > > building a git checkout: > > > > Failing build on warnings is a useful developer tool but its bad > > for release tarballs which can and do get built with newer > > compilers than what was used/available during development. Compilers > > routinely add new warnings so code which built silently with cc X > > might no longer do so with X+1. This doesn't make the existing code > > any more buggier and failing the build in this case does not help > > not help improve code quality of an already released version either. > > Please, could you update documentation to explain RTE_DEVEL_BUILD option? > Some users could try to build from git, so we should advise to disable > RTE_DEVEL_BUILD. > These files might be updated: > http://dpdk.org/browse/dpdk/tree/doc/build-sdk-quick.txt > http://dpdk.org/browse/dpdk/tree/doc/guides/linux_gsg/build_dpdk.rst > http://dpdk.org/browse/dpdk/tree/doc/guides/freebsd_gsg/build_dpdk.rst > > http://dpdk.org/browse/dpdk/tree/doc/guides/prog_guide/dev_kit_build_system.rst > > Thanks Also do not allow any patches to into upstream that cause new warnings with latest stable version of Gcc or Clang? I don't want a clean project to get littered with warning graffiti. Maybe a build bot?
