> -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Alexander Kozyrev > Sent: Friday, April 10, 2020 1:21 > To: Mohsin Shaikh <mohsinsha...@niometrics.com>; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib > stat > > > -----Original Message----- > > From: Mohsin Shaikh <mohsinsha...@niometrics.com> > > Sent: Thursday, April 9, 2020 16:37 > > To: dev@dpdk.org > > Cc: sta...@dpdk.org; Alexander Kozyrev <akozy...@mellanox.com>; > Mohsin > > Shaikh <mohsinsha...@niometrics.com> > > Subject: [PATCH] net/mlx5: use open/read/close for reading ib stat > > > > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to > > TLB shootdown interrupts to all dpdk app cores including RX cores. > > This can cause packet drops. Use read(2)/write(2) instead. > > > > Bugzilla ID: 440 > > Cc: sta...@dpdk.org > > > > Signed-off-by: Mohsin Shaikh <mohsinsha...@niometrics.com> > > --- > > Reviewed-by: Alexander Kozyrev <akozy...@mellanox.com> Acked-by: Viacheslav Ovsiienko <viachesl...@mellanox.com>
Thank you, Mohsin for the patch. Alexander, thank you for the review and test. With best regards, Slava
