> -----Original Message----- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, February 20, 2015 7:53 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when > read > > On Fri, 20 Feb 2015 18:32:03 +0000 > "Dumitrescu, Cristian" <cristian.dumitrescu at intel.com> wrote: > > > Stephen, I suggest adding a new build-time configuration option for the > librte_sched library in config/common_* files: > CONFIG_RTE_SCHED_STATS_CLEAR_ON_READ. > > Build time config options do not work for distributions.
Why? This does not affect the API, as the new API functions are always compiled in, and the prototypes are not changed, and no data structures are affected. This only changes the behavior of certain functions, so that user can select which mode it needs. It also preserves backward compatibility. We have so many compilation options in config file, why is this one different? -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
