On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote: > Hello, > > On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.lin...@pantheon.tech> > wrote: > > > > libjansson4 is not enough to build telemetry. Replace it with > > libjansson-dev. > > Thanks for the patch Juraj. > Just a little comment, for the v2, there was no significant change and > you could have kept Aaron and Ruifeng review tags. > > > I just want others' opinion, since there is a work on removing the > dependency on libjansson for telemetry. > That would be an end-goal but we are not fully there yet. Even with the rework some parts of the library for legacy compatibility still depend on jansson, though the majority of the code will compile without it. Therefore this dependency should be kept in the CI beyond this release, as we weren't planning on doing the additional work to completely replace it - though we can re-evaluate that if people think that it's important to remove the dependency completely.
/Bruce
