07/04/2020 12:25, Hemant Agrawal: > > In the mean time, the tooling can be tought to ignore changes to these ELF > > symbols, as you you guys all know already. > > > [Hemant] will you please help me about adding entry to libagigail.abignore > I tried doing following, but it is not helping > > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -2,10 +2,15 @@ > symbol_version = EXPERIMENTAL > [suppress_variable] > symbol_version = EXPERIMENTAL > + name = per_lcore__dpaa2_io > + name = dpaa2_io_portal > > ; Explicit ignore for driver-only ABI > [suppress_type] > name = rte_cryptodev_ops > + name = dpaa2_io_portal_t > > > > > Anyway, all of those symbols in dpaa are part of the driver ABI. > > > We are still missing a way to mark internal symbols. > > > Neil had posted a framework for this > > > > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwo > > rk.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D5004&data=02 > > %7C01%7Chemant.agrawal%40nxp.com%7C91a3230cfd334c28bbdb08d7c4d > > ee590%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371943339 > > 20186005&sdata=1Is%2BqQwP%2Bn0QVJ2HYK2%2Bx7TJooEvry1sNUUN > > fWMygkM%3D&reserved=0. > > > > > > In order to get this series passing the checks, I recommend NXP > > > rebasing Neil scripts (I will help reviewing this part), then mark all > > > those symbols as internal in its drivers. > > > Other vendor will convert their drivers later, as there is no need at > > > the moment. > > > > [Hemant] I have commented on Neil's series. > It needs more changes in existing code. > An approach like __rte_experimental will work better.
I guess you mean __rte_internal? Please Hemant don't wait for someone else filling the gap. If __rte_internal is the right approach, please complete and use it.
