Regards Sunil Kumar Kori >-----Original Message----- >From: David Marchand <david.march...@redhat.com> >Sent: Monday, April 6, 2020 6:52 PM >To: Sunil Kumar Kori <sk...@marvell.com> >Cc: Stephen Hemminger <step...@networkplumber.org>; Jerin Jacob >Kollanukkaran <jer...@marvell.com>; dev@dpdk.org >Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to >allowed devices > >On Mon, Apr 6, 2020 at 11:32 AM Sunil Kumar Kori <sk...@marvell.com> >wrote: >> It looks like there is no comment/objection on following patch and it can be >merged. > >The title does not reflect what this patch is about. >I understand this as an optimisation for the pci bus scanning. > > >I agree with Stephen comment. > >If you change pci_ignore_device and pci_devargs_lookup to take a >rte_pci_addr as input, then pci_ignore_device can call pci_devargs_lookup >itself. >And pci_devargs_lookup does not need to be exported in the private header. > >Untested (just tried compilation), >https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_david- >2Dmarchand_dpdk_commit_e7860231ecdce91f9f70027d4090a7057b8fd5f7& >d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=dXeXaAMkP5COgn1zxHMyaF1_d >9IIuq6vHQO6NrIPjaE&m=H7IQgd6gnpQBcbVgN952C_oIcMj5Z34kRhYngZr8Pyc >&s=eq-hCdZ-C4xZ0Y7rQEkYwJS04r5sh7G2I9CXHTuBmws&e= > > >-- >David Marchand
Okay. I will share updated version of this based on review comments.