On Mon, Apr 06, 2020 at 11:18:36AM +0530, Jerin Jacob wrote: > External Email > > ---------------------------------------------------------------------- > On Fri, Apr 3, 2020 at 2:24 PM Nithin Dabilpuram <nithind1...@gmail.com> > wrote: > > > > From: Krzysztof Kanas <kka...@marvell.com> > > > > Add Traffic Management capability callbacks to provide > > global, level and node capabilities. This patch also > > adds documentation on Traffic Management Support. > > > > Signed-off-by: Nithin Dabilpuram <ndabilpu...@marvell.com> > > Signed-off-by: Krzysztof Kanas <kka...@marvell.com> > > After fixing the below issues(inlined) > Series applied to dpdk-next-net-mrvl/master. Thanks. > > > > --- > > > > diff --git a/doc/guides/nics/features/octeontx2.ini > > b/doc/guides/nics/features/octeontx2.ini > > index 473fe56..fb13517 100644 > > --- a/doc/guides/nics/features/octeontx2.ini > > +++ b/doc/guides/nics/features/octeontx2.ini > > @@ -31,6 +31,7 @@ Inline protocol = Y > > VLAN filter = Y > > Flow control = Y > > Flow API = Y > > +Rate limitation = Y > > Definition this "Rate limitation" and TM rate limitation functionally > the same. But the interface is different. > Following is the interface for the above "Rate limitation" feature. > So, Above "Y" is not applicable.
Actually support to this feature is added via Patch 10/11. My bad, I added the document update in 11/11 which caused the confusion. Another reason is rate limit support depends on TM support in OCTEON TX2. I also missed to update octeontx2_vec.ini and octeontx2_vf.ini file. Can the above change be put back into Patch 10/11 ? Thanks for other corrections. > > Rate limitation > --------------- > > Supports Tx rate limitation for a queue. > > * **[implements] eth_dev_ops**: ``set_queue_rate_limit``. > * **[related] API**: ``rte_eth_set_queue_rate_limit()`` > > > > > > Jumbo frame = Y > > Scattered Rx = Y > > VLAN offload = Y > > diff --git a/doc/guides/nics/octeontx2.rst b/doc/guides/nics/octeontx2.rst > > index 60187ec..6b885d6 100644 > > --- a/doc/guides/nics/octeontx2.rst > > +++ b/doc/guides/nics/octeontx2.rst > > @@ -39,6 +39,7 @@ Features of the OCTEON TX2 Ethdev PMD are: > > - HW offloaded `ethdev Rx queue` to `eventdev event queue` packet injection > > - Support Rx interrupt > > - Inline IPsec processing support > > +- :ref:`Traffic Management API <tmapi>` > > tmapi ref is pointing to mvpp2 driver index. > > > > > > Prerequisites > > ------------- > > @@ -213,6 +214,20 @@ Runtime Config Options > > parameters to all the PCIe devices if application requires to configure > > on > > all the ethdev ports. > > > > +Traffic Management API > > +---------------------- > > + > > +OCTEON TX2 PMD supports generic DPDK Traffic Management API which allows to > > +configure the following features: > > + > > +1. Hierarchical scheduling > > +2. Single rate - two color, Two rate - three color shaping > > Use #. to auto enumerate. > > > + > > +Both DWRR and Static Priority(SP) hierarchial scheduling is supported. > > +Every parent can have atmost 10 SP Children and unlimited DWRR children. > > +Both PF & VF supports traffic management API with PF supporting 6 levels > > +and VF supporting 5 levels of topology. > > + > > Limitations > > ----------- > > > > diff --git a/doc/guides/rel_notes/release_20_05.rst > > b/doc/guides/rel_notes/release_20_05.rst > > index 000bbf5..47a9825 100644 > > --- a/doc/guides/rel_notes/release_20_05.rst > > +++ b/doc/guides/rel_notes/release_20_05.rst > > @@ -62,6 +62,14 @@ New Features > > > > * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit. > > > > +* **Updated Marvell OCTEON TX2 ethdev driver.** > > + > > + Updated Marvell OCTEON TX2 ethdev driver with traffic manager support with > > + below features. > > + > > + * Hierarchial Scheduling with DWRR and SP. > > + * Single rate - two color, Two rate - three color shaping. > > Alignment is not correct wrt to other items.
