On Sat, Apr 4, 2020 at 1:27 PM Wang, Xiao W <xiao.w.w...@intel.com> wrote:
> > +static void
> > +node_scan_dump(FILE *f, rte_node_t id, bool all)
> > +{
> > + struct node *node;
> > +
> > + RTE_ASSERT(f != NULL);
> > + NODE_ID_CHECK(id);
This one is using fail: jump. See below
> > + STAILQ_FOREACH(node, &node_list, next) {
> > + if (all == true) {
> > + node_dump(f, node);
> > + } else if (node->id == id) {
> > + node_dump(f, node);
> > + return;
> > + }
> > + }
> > +fail:
> we can remove this "fail" mark since it's not used as jmp target.
See above.
>
> > + return;
> > +}
>
